boha_admin/app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

revert(orders-pdf): remove the E-mail line from the issued-order footer

Browse Source 
Keeps the 'Vystavil: <name>' line (logged-in user) and the removed Schválil
signature row; drops the e-mail line + its param field/translation keys per
request.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
BOHA
2026-06-09 21:56:54 +02:00
parent 5462fcf944
commit 1e4dd1fbcc
2 changed files with 6 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/__tests__/issued-orders.test.ts
View File

@@ -276,7 +276,7 @@ describe("renderIssuedOrderHtml", () => {
},
];
const issuer = { name: "Jan Novák", email: "jan.novak@firma.cz" };
const issuer = { name: "Jan Novák" };
it("renders the PO number, items, and both party names (PO direction)", () => {
const html = renderIssuedOrderHtml(
@@ -305,23 +305,13 @@ describe("renderIssuedOrderHtml", () => {
expect(html).not.toContain("alert(1)");
});
it("footer shows the logged-in user's name + e-mail, not the Schválil column", () => {
it("footer shows the logged-in user's name, no e-mail, no Schválil column", () => {
const html = renderIssuedOrderHtml(order, items, null, null, "cs", issuer);
// New footer: Vystavil <name> + E-mail <email> from authData.
// Footer: Vystavil <name> from authData. No e-mail line.
expect(html).toContain("Jan Novák");
expect(html).toContain("jan.novak@firma.cz");
expect(html).toContain("E-mail:");
expect(html).not.toContain("E-mail:");
// The old two-column signature footer is gone.
expect(html).not.toContain("footer-row");
expect(html).not.toContain("Schválil:");
});
it("omits the e-mail line when the issuer has no e-mail", () => {
const html = renderIssuedOrderHtml(order, items, null, null, "cs", {
name: "Jan Novák",
email: "",
});
expect(html).toContain("Jan Novák");
expect(html).not.toContain("E-mail:");
});
});

8
src/routes/admin/issued-orders-pdf.ts
View File

@@ -187,7 +187,6 @@ const translations: Record<Lang, Record<string, string>> = {
delivery_terms: "Dodací podmínky:",
payment_terms: "Platební podmínky:",
issued_by: "Vystavil:",
email: "E-mail:",
ico: "IČ: ",
dic: "DIČ: ",
},
@@ -215,7 +214,6 @@ const translations: Record<Lang, Record<string, string>> = {
delivery_terms: "Delivery terms:",
payment_terms: "Payment terms:",
issued_by: "Issued by:",
email: "E-mail:",
ico: "Reg. No.: ",
dic: "Tax ID: ",
},
@@ -249,7 +247,7 @@ export function renderIssuedOrderHtml(
customer: Record<string, unknown> | null,
settings: Record<string, unknown> | null,
lang: Lang,
issuer: { name: string; email: string },
issuer: { name: string },
): string {
const t = translations[lang];
const applyVat = order.apply_vat !== false;
@@ -784,9 +782,8 @@ ${indentCSS}
</div><!-- /.invoice-content -->
<div class="invoice-footer">
<!-- Vystavil (jmeno + e-mail prihlaseneho uzivatele) -->
<!-- Vystavil (jmeno prihlaseneho uzivatele) -->
<div class="issued-by"><span class="lbl">${escapeHtml(t.issued_by)}</span> ${escapeHtml(issuer.name)}</div>
${issuer.email ? `<div class="issued-by"><span class="lbl">${escapeHtml(t.email)}</span> ${escapeHtml(issuer.email)}</div>` : ""}
</div><!-- /.invoice-footer -->
</div><!-- /.invoice-page -->
@@ -836,7 +833,6 @@ export default async function issuedOrdersPdfRoutes(fastify: FastifyInstance) {
// authData is always present here. Mirrors orders-pdf.ts userName.
const issuer = {
name: `${request.authData?.firstName ?? ""} ${request.authData?.lastName ?? ""}`.trim(),
email: request.authData?.email ?? "",
};
const html = renderIssuedOrderHtml(