519edce373
Validation: shared NaN-guarded Zod coercion helpers in schemas/common.ts replace the raw number|string transform idiom across every schema (the root-cause NaN bug class); emailOrEmpty + lenient isoDateString/timeString. Security: roles privilege-escalation closed; refresh-token family revocation on reuse; TOTP uses config params; read endpoints permission-guarded; received-invoices gross VAT on all paths; orders-pdf custom-items authz. Concurrency: $queryRaw SELECT...FOR UPDATE locks in ascending-id order (warehouse confirm/cancel, attendance lockUserRow); uniqueness checks moved into create transactions (TOCTOU -> 409); deterministic id tiebreak on second-precision timestamp ordering (plan resolveCell/resolveGrid, warehouse FIFO). Frontend: Rules-of-Hooks fixed across ~14 pages + PlanCellModal; UTC-date persisted fields; dashboard invalidation gaps; stale-closure confirm bugs. Tooling/tests: ESLint flat config (react-hooks/rules-of-hooks = error) + Prettier; tsconfig.test.json so tsc -b type-checks the tests; removed 3 dead deps; npm audit fix (8 -> 3). Suite 195 -> 247 (happy-path auth, FIFO oldest-first, flakiness fixes), isolated on app_test via .env.test with a hard-throw setup guard. Gates: tsc 0 | build 0 | vitest 247/247 | eslint 0 errors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
26 lines
1.0 KiB
TypeScript
26 lines
1.0 KiB
TypeScript
import { useEffect } from "react";
|
|
|
|
// NOTE: this hook locks `document.body.style.overflow` only. The app layout
|
|
// scrolls on `<html>` (GlobalStyles sets `html { overflow-x: hidden }`, which
|
|
// makes `<html>` the scroll container), so a body-only lock may not fully
|
|
// prevent background scroll. The kit's Modal/ConfirmDialog use
|
|
// `useDialogScrollLock`, which correctly locks `<html>`. This hook is retained
|
|
// only for the two non-kit in-page edit modals that still call it
|
|
// (AttendanceAdmin, WarehouseItemDetail); prefer `useDialogScrollLock` for new
|
|
// dialogs. Behavior intentionally left unchanged to avoid regressing those
|
|
// pages — see REVIEW_FINDINGS (useModalLock LOW).
|
|
let activeLocks = 0;
|
|
|
|
export default function useModalLock(isOpen: boolean): void {
|
|
useEffect(() => {
|
|
if (isOpen) {
|
|
if (activeLocks === 0) document.body.style.overflow = "hidden";
|
|
activeLocks++;
|
|
return () => {
|
|
activeLocks = Math.max(0, activeLocks - 1);
|
|
if (activeLocks === 0) document.body.style.overflow = "";
|
|
};
|
|
}
|
|
}, [isOpen]);
|
|
}
|