e11765bf0e
Critical (data integrity):
- warehouse inventory confirm: throw (not return) inside $transaction so a
failed deficit line rolls back the surplus corrective receipt — retries
no longer accumulate phantom stock
- warehouse issue confirm: validate batches against the COMBINED quantity
of all lines (duplicate FIFO-resolved lines drove batches negative)
- attendance delete: restore vacation_used/sick_used for the deleted day
(in-transaction, clamped at 0)
High:
- auth refresh: terminated sessions (replaced_at only) get a plain 401 —
the theft branch (family revocation) now fires only on replaced_by_hash
- POST /users strips role_id for non-admin callers (mirrors PUT guard)
- issued-order transition flushes unsaved edits via the full save payload
when dirty; server contract (items+status in one PUT) pinned
- received-invoices list: usePaginatedQuery + pager (rows 26+ unreachable)
- received-invoice dates: nullableIsoDateString + NaN guard before NAS save
(Czech-format dates corrupted month/year, orphaned NAS files)
- leave approval skips Czech public holidays and books each calendar year's
hours against its own balance (mirrors createLeave)
Medium/Low (classes):
- 52 Zod caps aligned to DB column widths across 7 schemas (over-cap input
500ed at Prisma instead of a Czech 400)
- FK pre-validation: projects update + warehouse receipts/issues return
Czech 400s instead of P2003 500s
- invoice PDF degrades gracefully when the CNB rate is unavailable
(recap omitted instead of 500 + lost NAS archival)
- date boundaries: local-day filters (warehouse lists/reports, audit-log),
@db.Date coercion on invoice dates
- plan updateEntry re-checks the per-cell cap (self-excluding)
- {id} tiebreaks on customers/received-invoices/warehouse-items sorts;
/items honors the client sort param
- htmlToPdf relaunches once when the shared browser died mid-render
- offer number release parses the year from the document number (cross-year
finalize+delete left permanent sequence gaps)
- trips/vehicles km fields integer-coerced; AI budget regated to
settings.company|settings.system; Settings System tab no longer clobbers
Firma numbering patterns; draft invoices hide the dead PDF button;
dashboard quick-trip invalidates ["vehicles"]; TOTP secret cap 64;
audit-log + invoice month buckets day-shift fixes
Docs: corrected the stale "Chromium has no CSS margin-box footers" claim
(html-to-pdf.ts + CLAUDE.md — margin boxes render since Chrome 131); audit
report M3 withdrawn accordingly.
~65 new pinning tests; every finding reproduced RED against the real test
DB before its fix. Suite: 58 files / 634 tests green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
77 lines
2.3 KiB
TypeScript
77 lines
2.3 KiB
TypeScript
import { describe, it, expect, beforeAll, afterAll } from "vitest";
|
|
import prisma from "../config/database";
|
|
import { updateProject } from "../services/projects.service";
|
|
|
|
/**
|
|
* Pinning tests for audit finding M6: updateProject must pre-validate FK ids
|
|
* (customer_id, responsible_user_id, quotation_id, order_id) and return clean
|
|
* Czech 400s like createProject does — a dangling id otherwise raises P2003
|
|
* at Prisma and surfaces as a generic 500.
|
|
*/
|
|
|
|
const N = "prj_fk_";
|
|
|
|
let projectId: number;
|
|
|
|
async function cleanup() {
|
|
await prisma.projects.deleteMany({ where: { name: { startsWith: N } } });
|
|
}
|
|
|
|
beforeAll(async () => {
|
|
await cleanup();
|
|
const project = await prisma.projects.create({
|
|
data: { name: `${N}project`, status: "active" },
|
|
});
|
|
projectId = project.id;
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await cleanup();
|
|
await prisma.$disconnect();
|
|
});
|
|
|
|
function isError(r: unknown): r is { error: string; status: number } {
|
|
return typeof r === "object" && r !== null && "error" in r;
|
|
}
|
|
|
|
describe("updateProject FK existence checks (audit M6)", () => {
|
|
it.each([
|
|
["customer_id", "Zákazník nenalezen"],
|
|
["responsible_user_id", "Zodpovědná osoba nenalezena"],
|
|
["quotation_id", "Nabídka nenalezena"],
|
|
["order_id", "Zakázka nenalezena"],
|
|
])("returns a Czech 400 for a dangling %s", async (field, message) => {
|
|
const result = await updateProject(projectId, { [field]: 99999999 });
|
|
|
|
expect(isError(result)).toBe(true);
|
|
if (isError(result)) {
|
|
expect(result.status).toBe(400);
|
|
expect(result.error).toBe(message);
|
|
}
|
|
|
|
// Nothing was written.
|
|
const fresh = await prisma.projects.findUnique({
|
|
where: { id: projectId },
|
|
});
|
|
expect(fresh?.[field as "customer_id"]).toBeNull();
|
|
});
|
|
|
|
it("still allows clearing an FK with null", async () => {
|
|
const result = await updateProject(projectId, { customer_id: null });
|
|
expect(isError(result)).toBe(false);
|
|
});
|
|
|
|
it("still allows setting a valid FK", async () => {
|
|
const user = await prisma.users.findFirst({ select: { id: true } });
|
|
expect(user).not.toBeNull();
|
|
const result = await updateProject(projectId, {
|
|
responsible_user_id: user!.id,
|
|
});
|
|
expect(isError(result)).toBe(false);
|
|
const fresh = await prisma.projects.findUnique({
|
|
where: { id: projectId },
|
|
});
|
|
expect(fresh?.responsible_user_id).toBe(user!.id);
|
|
});
|
|
});
|