1826fc7976
Fixes every CRITICAL/HIGH finding from the 2026-06-09 full-codebase audit
(REVIEW_FINDINGS.md); each fix went through independent spec + code-quality
review. Plan and per-task log: docs/superpowers/plans/2026-06-10-audit-high-fix-pass.md
- attendance: schemas accept the combined local datetimes the forms/service
use (new dateTimeString helpers in schemas/common.ts), breaks persist on
create, AttendanceCreate submit rebuilt — every submit 400'd since 519edce
- 2fa: backup codes wired to /totp/backup-verify (+ remember-me parity),
enrollment QR generated locally via qrcode (CSP-blocked external service
also leaked the secret), dashboard shows per-user enrollment, not policy
- invoices/orders: per-line VAT survives re-saves (numberOr 0-respecting
coercion in formatters.ts), billing_text persists on update, issued-order
status transitions update UI gates
- trips: real pagination on all 3 pages, GET /trips/stats server aggregate
(shared buildTripsWhere + legacy distance coalesce), vehicle_id applies on
PUT with both-vehicle odometer recompute, print rebuilt (sync window.open,
escaped template, server totals)
- orders api: attachment_data PDF blob excluded from all non-binary reads
- warehouse: unit field is a Select over UnitEnum, receipt attachments
downloadable via new authenticated GET route
- downloads: shared RFC 5987 contentDisposition helper — Czech filenames no
longer 500 (warehouse, received-invoices, orders endpoints)
- misc: block-env hook actually blocks (exit 2 + stderr), project create
works with empty dates, NaN filter guards on trips endpoints
- deps: remove unused concurrently (clears both critical advisories), pin
@hono/node-server >=1.19.13 via overrides (clears the 3 moderates without
the Prisma 6 downgrade), drop deprecated @types stubs
Gates: tsc -b clean - vitest 30 files / 342 tests (31 new) - eslint 0 errors
- build OK
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
24 lines
968 B
JavaScript
24 lines
968 B
JavaScript
// Block direct .env file edits (not .env.example, .env.production, .env.test)
|
|
//
|
|
// Hook exit-code contract (Claude Code PreToolUse):
|
|
// exit 0 = allow (stdout JSON is only parsed on exit 0)
|
|
// exit 2 = BLOCK — the reason must be written to STDERR
|
|
// any other exit code = non-blocking error (the tool call proceeds)
|
|
// So to actually block, we must print to stderr and exit 2.
|
|
let data = "";
|
|
process.stdin.on("data", (chunk) => (data += chunk));
|
|
process.stdin.on("end", () => {
|
|
try {
|
|
const input = JSON.parse(data);
|
|
const filePath = input.tool_input?.file_path || "";
|
|
const basename = filePath.split("/").pop().split("\\").pop();
|
|
if (basename === ".env") {
|
|
console.error("Direct .env edits are blocked. Use .env.example instead.");
|
|
process.exit(2);
|
|
}
|
|
} catch {
|
|
// Deliberate fail-open: on unparseable input exit 0 (allow). Exiting 2
|
|
// here would block EVERY Edit/Write if the hook payload format changed.
|
|
}
|
|
});
|