test(auth): update verifyAccessToken tests to assert no-log for expected token errors
The JWT log-noise fix (88c9b7c) stopped logging expected invalid/expired tokens, but auth.service.test.ts still asserted it logged, leaving 2 failing tests on master/v1.9.0 (a wrong auth test file was run when that change landed). Tests now assert null + no console.error for JsonWebTokenError cases.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -5,18 +5,20 @@ import { config } from "../config/env";
|
|||||||
|
|
||||||
describe("auth service", () => {
|
describe("auth service", () => {
|
||||||
describe("verifyAccessToken", () => {
|
describe("verifyAccessToken", () => {
|
||||||
it("returns null and logs error for invalid JWT", async () => {
|
it("returns null WITHOUT logging for an invalid JWT (expected condition)", async () => {
|
||||||
const consoleSpy = vi
|
const consoleSpy = vi
|
||||||
.spyOn(console, "error")
|
.spyOn(console, "error")
|
||||||
.mockImplementation(() => {});
|
.mockImplementation(() => {});
|
||||||
const result = await verifyAccessToken("invalid-token");
|
const result = await verifyAccessToken("invalid-token");
|
||||||
expect(result).toBeNull();
|
expect(result).toBeNull();
|
||||||
expect(consoleSpy).toHaveBeenCalled();
|
// Invalid/expired access tokens are an expected condition (the client
|
||||||
expect(consoleSpy.mock.calls[0][0]).toMatch(/JWT verification error/);
|
// refreshes on the resulting 401), so verifyAccessToken deliberately
|
||||||
|
// does NOT log them as errors — only genuinely unexpected failures.
|
||||||
|
expect(consoleSpy).not.toHaveBeenCalled();
|
||||||
consoleSpy.mockRestore();
|
consoleSpy.mockRestore();
|
||||||
});
|
});
|
||||||
|
|
||||||
it("returns null for expired JWT", async () => {
|
it("returns null WITHOUT logging for an expired JWT", async () => {
|
||||||
const consoleSpy = vi
|
const consoleSpy = vi
|
||||||
.spyOn(console, "error")
|
.spyOn(console, "error")
|
||||||
.mockImplementation(() => {});
|
.mockImplementation(() => {});
|
||||||
@@ -27,7 +29,7 @@ describe("auth service", () => {
|
|||||||
);
|
);
|
||||||
const result = await verifyAccessToken(expiredToken);
|
const result = await verifyAccessToken(expiredToken);
|
||||||
expect(result).toBeNull();
|
expect(result).toBeNull();
|
||||||
expect(consoleSpy).toHaveBeenCalled();
|
expect(consoleSpy).not.toHaveBeenCalled();
|
||||||
consoleSpy.mockRestore();
|
consoleSpy.mockRestore();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
Reference in New Issue
Block a user