boha_admin/app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

fix: 2026-06-09 full-codebase audit hardening

Browse Source 
Validation: shared NaN-guarded Zod coercion helpers in schemas/common.ts replace
the raw number|string transform idiom across every schema (the root-cause NaN bug
class); emailOrEmpty + lenient isoDateString/timeString.

Security: roles privilege-escalation closed; refresh-token family revocation on
reuse; TOTP uses config params; read endpoints permission-guarded; received-invoices
gross VAT on all paths; orders-pdf custom-items authz.

Concurrency: $queryRaw SELECT...FOR UPDATE locks in ascending-id order (warehouse
confirm/cancel, attendance lockUserRow); uniqueness checks moved into create
transactions (TOCTOU -> 409); deterministic id tiebreak on second-precision
timestamp ordering (plan resolveCell/resolveGrid, warehouse FIFO).

Frontend: Rules-of-Hooks fixed across ~14 pages + PlanCellModal; UTC-date persisted
fields; dashboard invalidation gaps; stale-closure confirm bugs.

Tooling/tests: ESLint flat config (react-hooks/rules-of-hooks = error) + Prettier;
tsconfig.test.json so tsc -b type-checks the tests; removed 3 dead deps; npm audit
fix (8 -> 3). Suite 195 -> 247 (happy-path auth, FIFO oldest-first, flakiness fixes),
isolated on app_test via .env.test with a hard-throw setup guard.

Gates: tsc 0 | build 0 | vitest 247/247 | eslint 0 errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
BOHA
2026-06-09 06:45:26 +02:00
parent c454d1a3fc
commit 519edce373
179 changed files with 7179 additions and 2844 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/utils/html-to-pdf.ts
View File

@@ -1,5 +1,33 @@
import fs from "fs";
import { Browser } from "puppeteer";
/**
* Pick the first Chromium executable that actually exists on disk.
* The previous `A || B || C` chain was dead: the second operand
* ("/usr/bin/chromium-browser") is always truthy, so the third
* ("/usr/bin/chromium") was never reached and launch failed on hosts
* that only ship the `chromium` binary. We now probe each candidate
* with fs.existsSync and fall through to the next.
*/
function resolveChromiumPath(): string | undefined {
const candidates = [
process.env.CHROMIUM_PATH,
"/usr/bin/chromium-browser",
"/usr/bin/chromium",
].filter((p): p is string => Boolean(p));
for (const candidate of candidates) {
try {
if (fs.existsSync(candidate)) return candidate;
} catch {
// existsSync should not throw, but if it does treat as "not found"
// and continue probing the next candidate.
}
}
// Nothing on disk matched — fall back to the configured env value (if any)
// so puppeteer-core surfaces a meaningful launch error instead of "undefined".
return process.env.CHROMIUM_PATH || undefined;
}
let browser: Browser | null = null;
let launching: Promise<Browser> | null = null;
@@ -18,10 +46,7 @@ async function getBrowser(): Promise<Browser> {
});
} catch {
const core = await import("puppeteer-core");
const executablePath =
process.env.CHROMIUM_PATH ||
"/usr/bin/chromium-browser" ||
"/usr/bin/chromium";
const executablePath = resolveChromiumPath();
browser = await core.default.launch({
headless: true,
executablePath,