boha_admin/app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

fix: 2026-06-09 full-codebase audit hardening

Browse Source 
Validation: shared NaN-guarded Zod coercion helpers in schemas/common.ts replace
the raw number|string transform idiom across every schema (the root-cause NaN bug
class); emailOrEmpty + lenient isoDateString/timeString.

Security: roles privilege-escalation closed; refresh-token family revocation on
reuse; TOTP uses config params; read endpoints permission-guarded; received-invoices
gross VAT on all paths; orders-pdf custom-items authz.

Concurrency: $queryRaw SELECT...FOR UPDATE locks in ascending-id order (warehouse
confirm/cancel, attendance lockUserRow); uniqueness checks moved into create
transactions (TOCTOU -> 409); deterministic id tiebreak on second-precision
timestamp ordering (plan resolveCell/resolveGrid, warehouse FIFO).

Frontend: Rules-of-Hooks fixed across ~14 pages + PlanCellModal; UTC-date persisted
fields; dashboard invalidation gaps; stale-closure confirm bugs.

Tooling/tests: ESLint flat config (react-hooks/rules-of-hooks = error) + Prettier;
tsconfig.test.json so tsc -b type-checks the tests; removed 3 dead deps; npm audit
fix (8 -> 3). Suite 195 -> 247 (happy-path auth, FIFO oldest-first, flakiness fixes),
isolated on app_test via .env.test with a hard-throw setup guard.

Gates: tsc 0 | build 0 | vitest 247/247 | eslint 0 errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
BOHA
2026-06-09 06:45:26 +02:00
parent c454d1a3fc
commit 519edce373
179 changed files with 7179 additions and 2844 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/services/system-settings.ts
View File

@@ -53,15 +53,26 @@ export async function getSystemSettings(): Promise<SystemSettings> {
let vatRates = DEFAULTS.available_vat_rates;
let currencies = DEFAULTS.available_currencies;
try {
if (row.available_vat_rates) vatRates = JSON.parse(row.available_vat_rates);
if (row.available_vat_rates) {
const parsed = JSON.parse(row.available_vat_rates);
// Shape guard: must be an array of finite numbers, else keep default.
if (Array.isArray(parsed) && parsed.every((n) => Number.isFinite(n))) {
vatRates = parsed;
}
}
} catch {
/* keep default */
/* malformed JSON — keep default (expected-condition catch) */
}
try {
if (row.available_currencies)
currencies = JSON.parse(row.available_currencies);
if (row.available_currencies) {
const parsed = JSON.parse(row.available_currencies);
// Shape guard: must be an array of strings, else keep default.
if (Array.isArray(parsed) && parsed.every((c) => typeof c === "string")) {
currencies = parsed;
}
}
} catch {
/* keep default */
/* malformed JSON — keep default (expected-condition catch) */
}
cache = {