boha_admin/app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

fix: 2026-06-09 full-codebase audit hardening

Browse Source 
Validation: shared NaN-guarded Zod coercion helpers in schemas/common.ts replace
the raw number|string transform idiom across every schema (the root-cause NaN bug
class); emailOrEmpty + lenient isoDateString/timeString.

Security: roles privilege-escalation closed; refresh-token family revocation on
reuse; TOTP uses config params; read endpoints permission-guarded; received-invoices
gross VAT on all paths; orders-pdf custom-items authz.

Concurrency: $queryRaw SELECT...FOR UPDATE locks in ascending-id order (warehouse
confirm/cancel, attendance lockUserRow); uniqueness checks moved into create
transactions (TOCTOU -> 409); deterministic id tiebreak on second-precision
timestamp ordering (plan resolveCell/resolveGrid, warehouse FIFO).

Frontend: Rules-of-Hooks fixed across ~14 pages + PlanCellModal; UTC-date persisted
fields; dashboard invalidation gaps; stale-closure confirm bugs.

Tooling/tests: ESLint flat config (react-hooks/rules-of-hooks = error) + Prettier;
tsconfig.test.json so tsc -b type-checks the tests; removed 3 dead deps; npm audit
fix (8 -> 3). Suite 195 -> 247 (happy-path auth, FIFO oldest-first, flakiness fixes),
isolated on app_test via .env.test with a hard-throw setup guard.

Gates: tsc 0 | build 0 | vitest 247/247 | eslint 0 errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
BOHA
2026-06-09 06:45:26 +02:00
parent c454d1a3fc
commit 519edce373
179 changed files with 7179 additions and 2844 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/services/projects.service.ts
View File

@@ -140,10 +140,16 @@ export async function updateProject(id: number, body: Record<string, any>) {
existing.project_number &&
nasFileManager.isConfigured()
) {
nasFileManager.renameProjectFolder(
const renamed = nasFileManager.renameProjectFolder(
existing.project_number,
String(body.name || ""),
);
if (!renamed) {
console.error(
"[projects.service] NAS folder not renamed for project",
existing.project_number,
);
}
}
return updated;
@@ -214,12 +220,24 @@ export async function deleteProject(id: number, deleteFiles: boolean = false) {
if (!existing) return { error: "not_found" as const };
if (existing.order_id) return { error: "has_order" as const };
if (deleteFiles && existing.project_number && nasFileManager.isConfigured()) {
await nasFileManager.deleteProjectFolder(existing.project_number);
}
// Delete the DB row FIRST, then the NAS folder (mirrors orders.service
// ordering). If the DB delete fails the folder is left untouched, so a DB
// failure can't orphan the folder; conversely the NAS cleanup is best-effort
// and non-fatal — a NAS error must not undo the committed DB delete.
await prisma.projects.delete({ where: { id } });
if (deleteFiles && existing.project_number && nasFileManager.isConfigured()) {
const ok = await nasFileManager.deleteProjectFolder(
existing.project_number,
);
if (!ok) {
console.error(
"[projects.service] NAS folder not deleted for project",
existing.project_number,
);
}
}
const year = existing.created_at
? new Date(existing.created_at).getFullYear()
: new Date().getFullYear();