fix: 2026-06-09 full-codebase audit hardening

Validation: shared NaN-guarded Zod coercion helpers in schemas/common.ts replace
the raw number|string transform idiom across every schema (the root-cause NaN bug
class); emailOrEmpty + lenient isoDateString/timeString.

Security: roles privilege-escalation closed; refresh-token family revocation on
reuse; TOTP uses config params; read endpoints permission-guarded; received-invoices
gross VAT on all paths; orders-pdf custom-items authz.

Concurrency: $queryRaw SELECT...FOR UPDATE locks in ascending-id order (warehouse
confirm/cancel, attendance lockUserRow); uniqueness checks moved into create
transactions (TOCTOU -> 409); deterministic id tiebreak on second-precision
timestamp ordering (plan resolveCell/resolveGrid, warehouse FIFO).

Frontend: Rules-of-Hooks fixed across ~14 pages + PlanCellModal; UTC-date persisted
fields; dashboard invalidation gaps; stale-closure confirm bugs.

Tooling/tests: ESLint flat config (react-hooks/rules-of-hooks = error) + Prettier;
tsconfig.test.json so tsc -b type-checks the tests; removed 3 dead deps; npm audit
fix (8 -> 3). Suite 195 -> 247 (happy-path auth, FIFO oldest-first, flakiness fixes),
isolated on app_test via .env.test with a hard-throw setup guard.

Gates: tsc 0 | build 0 | vitest 247/247 | eslint 0 errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
BOHA
2026-06-09 06:45:26 +02:00
parent c454d1a3fc
commit 519edce373
179 changed files with 7179 additions and 2844 deletions

View File

@@ -1,74 +1,68 @@
import { z } from "zod";
import {
numberFromForm,
nonNegativeNumberFromForm,
positiveNumberFromForm,
intIdFromForm,
nullableNumberFromForm,
nullableIntIdFromForm,
booleanFromForm,
isoDateString,
emailOrEmpty,
} from "./common";
// === Categories ===
export const CreateCategorySchema = z.object({
name: z.string().min(1, "Název je povinný"),
description: z.string().nullish(),
sort_order: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional()
.default(0),
name: z.string().min(1, "Název je povinný").max(255),
description: z.string().max(5000).nullish(),
sort_order: numberFromForm.optional().default(0),
});
export const UpdateCategorySchema = z.object({
name: z.string().min(1, "Název je povinný").optional(),
description: z.string().nullish(),
sort_order: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
name: z.string().min(1, "Název je povinný").max(255).optional(),
description: z.string().max(5000).nullish(),
sort_order: numberFromForm.optional(),
});
export type CreateCategoryInput = z.infer<typeof CreateCategorySchema>;
export type UpdateCategoryInput = z.infer<typeof UpdateCategorySchema>;
// === Suppliers ===
export const CreateSupplierSchema = z.object({
name: z.string().min(1, "Název je povinný"),
ico: z.string().nullish(),
dic: z.string().nullish(),
contact_person: z.string().nullish(),
email: z.string().nullish(),
phone: z.string().nullish(),
address: z.string().nullish(),
notes: z.string().nullish(),
is_active: z
.preprocess((v) => v === true || v === 1 || v === "1", z.boolean())
.optional()
.default(true),
name: z.string().min(1, "Název je povinný").max(255),
ico: z.string().max(255).nullish(),
dic: z.string().max(255).nullish(),
contact_person: z.string().max(255).nullish(),
email: emailOrEmpty.nullish(),
phone: z.string().max(50).nullish(),
address: z.string().max(5000).nullish(),
notes: z.string().max(5000).nullish(),
is_active: booleanFromForm.optional().default(true),
});
export const UpdateSupplierSchema = z.object({
name: z.string().min(1, "Název je povinný").optional(),
ico: z.string().nullish(),
dic: z.string().nullish(),
contact_person: z.string().nullish(),
email: z.string().nullish(),
phone: z.string().nullish(),
address: z.string().nullish(),
notes: z.string().nullish(),
is_active: z
.preprocess((v) => v === true || v === 1 || v === "1", z.boolean())
.optional(),
name: z.string().min(1, "Název je povinný").max(255).optional(),
ico: z.string().max(255).nullish(),
dic: z.string().max(255).nullish(),
contact_person: z.string().max(255).nullish(),
email: emailOrEmpty.nullish(),
phone: z.string().max(50).nullish(),
address: z.string().max(5000).nullish(),
notes: z.string().max(5000).nullish(),
is_active: booleanFromForm.optional(),
});
export type CreateSupplierInput = z.infer<typeof CreateSupplierSchema>;
export type UpdateSupplierInput = z.infer<typeof UpdateSupplierSchema>;
// === Locations ===
export const CreateLocationSchema = z.object({
code: z.string().min(1, "Kód je povinný"),
name: z.string().min(1, "Název je povinný"),
description: z.string().nullish(),
is_active: z
.preprocess((v) => v === true || v === 1 || v === "1", z.boolean())
.optional()
.default(true),
code: z.string().min(1, "Kód je povinný").max(255),
name: z.string().min(1, "Název je povinný").max(255),
description: z.string().max(5000).nullish(),
is_active: booleanFromForm.optional().default(true),
});
export const UpdateLocationSchema = z.object({
code: z.string().min(1, "Kód je povinný").optional(),
name: z.string().min(1, "Název je povinný").optional(),
description: z.string().nullish(),
is_active: z
.preprocess((v) => v === true || v === 1 || v === "1", z.boolean())
.optional(),
code: z.string().min(1, "Kód je povinný").max(255).optional(),
name: z.string().min(1, "Název je povinný").max(255).optional(),
description: z.string().max(5000).nullish(),
is_active: booleanFromForm.optional(),
});
export type CreateLocationInput = z.infer<typeof CreateLocationSchema>;
export type UpdateLocationInput = z.infer<typeof UpdateLocationSchema>;
@@ -79,77 +73,51 @@ export const UnitEnum = z.enum(UNIT_LIST);
export type Unit = z.infer<typeof UnitEnum>;
export const CreateItemSchema = z.object({
item_number: z.string().nullish(),
name: z.string().min(1, "Název je povinný"),
description: z.string().nullish(),
category_id: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
item_number: z.string().max(255).nullish(),
name: z.string().min(1, "Název je povinný").max(255),
description: z.string().max(5000).nullish(),
category_id: nullableIntIdFromForm.nullish(),
unit: UnitEnum,
min_quantity: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
notes: z.string().nullish(),
is_active: z
.preprocess((v) => v === true || v === 1 || v === "1", z.boolean())
.optional()
.default(true),
min_quantity: nullableNumberFromForm.nullish(),
notes: z.string().max(5000).nullish(),
is_active: booleanFromForm.optional().default(true),
});
export const UpdateItemSchema = z.object({
item_number: z.string().nullish(),
name: z.string().min(1, "Název je povinný").optional(),
description: z.string().nullish(),
category_id: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
item_number: z.string().max(255).nullish(),
name: z.string().min(1, "Název je povinný").max(255).optional(),
description: z.string().max(5000).nullish(),
category_id: nullableIntIdFromForm.nullish(),
unit: UnitEnum.optional(),
min_quantity: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
notes: z.string().nullish(),
is_active: z
.preprocess((v) => v === true || v === 1 || v === "1", z.boolean())
.optional(),
min_quantity: nullableNumberFromForm.nullish(),
notes: z.string().max(5000).nullish(),
is_active: booleanFromForm.optional(),
});
export type CreateItemInput = z.infer<typeof CreateItemSchema>;
export type UpdateItemInput = z.infer<typeof UpdateItemSchema>;
// === Receipts ===
export const ReceiptItemSchema = z.object({
item_id: z.union([z.number(), z.string()]).transform((v) => Number(v)),
quantity: z.union([z.number(), z.string()]).transform((v) => Number(v)),
unit_price: z.union([z.number(), z.string()]).transform((v) => Number(v)),
location_id: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
notes: z.string().nullish(),
item_id: intIdFromForm,
quantity: positiveNumberFromForm,
unit_price: nonNegativeNumberFromForm,
location_id: nullableIntIdFromForm.nullish(),
notes: z.string().max(5000).nullish(),
});
export const CreateReceiptSchema = z.object({
supplier_id: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
delivery_note_number: z.string().nullish(),
delivery_note_date: z.union([z.string(), z.null()]).nullish(),
notes: z.string().nullish(),
supplier_id: nullableIntIdFromForm.nullish(),
delivery_note_number: z.string().max(255).nullish(),
delivery_note_date: isoDateString.nullish(),
notes: z.string().max(5000).nullish(),
items: z
.array(ReceiptItemSchema)
.min(1, "Příjem musí obsahovat alespoň jednu položku"),
});
export const UpdateReceiptSchema = z.object({
supplier_id: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
delivery_note_number: z.string().nullish(),
delivery_note_date: z.union([z.string(), z.null()]).nullish(),
notes: z.string().nullish(),
supplier_id: nullableIntIdFromForm.nullish(),
delivery_note_number: z.string().max(255).nullish(),
delivery_note_date: isoDateString.nullish(),
notes: z.string().max(5000).nullish(),
items: z
.array(ReceiptItemSchema)
.min(1, "Příjem musí obsahovat alespoň jednu položku")
@@ -161,36 +129,24 @@ export type ReceiptItemInput = z.infer<typeof ReceiptItemSchema>;
// === Issues ===
export const IssueItemSchema = z.object({
item_id: z.union([z.number(), z.string()]).transform((v) => Number(v)),
batch_id: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.nullish(),
quantity: z.union([z.number(), z.string()]).transform((v) => Number(v)),
location_id: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
reservation_id: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
notes: z.string().nullish(),
item_id: intIdFromForm,
batch_id: nullableIntIdFromForm.nullish(),
quantity: positiveNumberFromForm,
location_id: nullableIntIdFromForm.nullish(),
reservation_id: nullableIntIdFromForm.nullish(),
notes: z.string().max(5000).nullish(),
});
export const CreateIssueSchema = z.object({
project_id: z.union([z.number(), z.string()]).transform((v) => Number(v)),
notes: z.string().nullish(),
project_id: intIdFromForm,
notes: z.string().max(5000).nullish(),
items: z
.array(IssueItemSchema)
.min(1, "Výdej musí obsahovat alespoň jednu položku"),
});
export const UpdateIssueSchema = z.object({
project_id: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
notes: z.string().nullish(),
project_id: intIdFromForm.optional(),
notes: z.string().max(5000).nullish(),
items: z
.array(IssueItemSchema)
.min(1, "Výdej musí obsahovat alespoň jednu položku")
@@ -202,32 +158,29 @@ export type IssueItemInput = z.infer<typeof IssueItemSchema>;
// === Reservations ===
export const CreateReservationSchema = z.object({
item_id: z.union([z.number(), z.string()]).transform((v) => Number(v)),
project_id: z.union([z.number(), z.string()]).transform((v) => Number(v)),
quantity: z.union([z.number(), z.string()]).transform((v) => Number(v)),
notes: z.string().nullish(),
item_id: intIdFromForm,
project_id: intIdFromForm,
quantity: positiveNumberFromForm,
notes: z.string().max(5000).nullish(),
});
export type CreateReservationInput = z.infer<typeof CreateReservationSchema>;
// === Inventory ===
export const InventoryItemSchema = z.object({
item_id: z.union([z.number(), z.string()]).transform((v) => Number(v)),
location_id: z
.union([z.number(), z.string(), z.null()])
.transform((v) => (v === null ? null : Number(v)))
.nullish(),
actual_qty: z.union([z.number(), z.string()]).transform((v) => Number(v)),
notes: z.string().nullish(),
item_id: intIdFromForm,
location_id: nullableIntIdFromForm.nullish(),
actual_qty: nonNegativeNumberFromForm,
notes: z.string().max(5000).nullish(),
});
export const CreateInventorySessionSchema = z.object({
notes: z.string().nullish(),
notes: z.string().max(5000).nullish(),
items: z
.array(InventoryItemSchema)
.min(1, "Inventura musí obsahovat alespoň jednu položku"),
});
export const UpdateInventorySessionSchema = z.object({
notes: z.string().nullish(),
notes: z.string().max(5000).nullish(),
items: z
.array(InventoryItemSchema)
.min(1, "Inventura musí obsahovat alespoň jednu položku")