fix: 2026-06-09 full-codebase audit hardening
Validation: shared NaN-guarded Zod coercion helpers in schemas/common.ts replace the raw number|string transform idiom across every schema (the root-cause NaN bug class); emailOrEmpty + lenient isoDateString/timeString. Security: roles privilege-escalation closed; refresh-token family revocation on reuse; TOTP uses config params; read endpoints permission-guarded; received-invoices gross VAT on all paths; orders-pdf custom-items authz. Concurrency: $queryRaw SELECT...FOR UPDATE locks in ascending-id order (warehouse confirm/cancel, attendance lockUserRow); uniqueness checks moved into create transactions (TOCTOU -> 409); deterministic id tiebreak on second-precision timestamp ordering (plan resolveCell/resolveGrid, warehouse FIFO). Frontend: Rules-of-Hooks fixed across ~14 pages + PlanCellModal; UTC-date persisted fields; dashboard invalidation gaps; stale-closure confirm bugs. Tooling/tests: ESLint flat config (react-hooks/rules-of-hooks = error) + Prettier; tsconfig.test.json so tsc -b type-checks the tests; removed 3 dead deps; npm audit fix (8 -> 3). Suite 195 -> 247 (happy-path auth, FIFO oldest-first, flakiness fixes), isolated on app_test via .env.test with a hard-throw setup guard. Gates: tsc 0 | build 0 | vitest 247/247 | eslint 0 errors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,41 +1,33 @@
|
||||
import { z } from "zod";
|
||||
import {
|
||||
intIdFromForm,
|
||||
nonNegativeNumberFromForm,
|
||||
booleanFromForm,
|
||||
isoDateString,
|
||||
} from "./common";
|
||||
|
||||
export const CreateTripSchema = z.object({
|
||||
vehicle_id: z.union([z.number(), z.string()]).transform((v) => Number(v)),
|
||||
vehicle_id: intIdFromForm,
|
||||
// user_id is optional here because the route injects it from authData.userId
|
||||
// when the client doesn't provide it (see POST /trips handler)
|
||||
user_id: z
|
||||
.union([z.number(), z.string()])
|
||||
.transform((v) => Number(v))
|
||||
.optional(),
|
||||
trip_date: z.string(),
|
||||
start_km: z.union([z.number(), z.string()]).transform((v) => Number(v)),
|
||||
end_km: z.union([z.number(), z.string()]).transform((v) => Number(v)),
|
||||
route_from: z.string(),
|
||||
route_to: z.string(),
|
||||
is_business: z
|
||||
.preprocess((v) => v === true || v === 1 || v === "1", z.boolean())
|
||||
.optional()
|
||||
.default(false),
|
||||
notes: z.string().nullish(),
|
||||
user_id: intIdFromForm.optional(),
|
||||
trip_date: isoDateString,
|
||||
start_km: nonNegativeNumberFromForm,
|
||||
end_km: nonNegativeNumberFromForm,
|
||||
route_from: z.string().min(1, "Vyplňte odkud").max(255),
|
||||
route_to: z.string().min(1, "Vyplňte kam").max(255),
|
||||
is_business: booleanFromForm.optional().default(false),
|
||||
notes: z.string().max(2000).nullish(),
|
||||
});
|
||||
|
||||
export const UpdateTripSchema = z.object({
|
||||
trip_date: z.string().optional(),
|
||||
start_km: z
|
||||
.union([z.number(), z.string()])
|
||||
.transform((v) => Number(v))
|
||||
.optional(),
|
||||
end_km: z
|
||||
.union([z.number(), z.string()])
|
||||
.transform((v) => Number(v))
|
||||
.optional(),
|
||||
route_from: z.string().optional(),
|
||||
route_to: z.string().optional(),
|
||||
is_business: z
|
||||
.preprocess((v) => v === true || v === 1 || v === "1", z.boolean())
|
||||
.optional(),
|
||||
notes: z.string().nullish(),
|
||||
trip_date: isoDateString.optional(),
|
||||
start_km: nonNegativeNumberFromForm.optional(),
|
||||
end_km: nonNegativeNumberFromForm.optional(),
|
||||
route_from: z.string().min(1, "Vyplňte odkud").max(255).optional(),
|
||||
route_to: z.string().min(1, "Vyplňte kam").max(255).optional(),
|
||||
is_business: booleanFromForm.optional(),
|
||||
notes: z.string().max(2000).nullish(),
|
||||
});
|
||||
|
||||
export type CreateTripInput = z.infer<typeof CreateTripSchema>;
|
||||
|
||||
Reference in New Issue
Block a user