boha_admin/app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

fix: 2026-06-09 full-codebase audit hardening

Browse Source 
Validation: shared NaN-guarded Zod coercion helpers in schemas/common.ts replace
the raw number|string transform idiom across every schema (the root-cause NaN bug
class); emailOrEmpty + lenient isoDateString/timeString.

Security: roles privilege-escalation closed; refresh-token family revocation on
reuse; TOTP uses config params; read endpoints permission-guarded; received-invoices
gross VAT on all paths; orders-pdf custom-items authz.

Concurrency: $queryRaw SELECT...FOR UPDATE locks in ascending-id order (warehouse
confirm/cancel, attendance lockUserRow); uniqueness checks moved into create
transactions (TOCTOU -> 409); deterministic id tiebreak on second-precision
timestamp ordering (plan resolveCell/resolveGrid, warehouse FIFO).

Frontend: Rules-of-Hooks fixed across ~14 pages + PlanCellModal; UTC-date persisted
fields; dashboard invalidation gaps; stale-closure confirm bugs.

Tooling/tests: ESLint flat config (react-hooks/rules-of-hooks = error) + Prettier;
tsconfig.test.json so tsc -b type-checks the tests; removed 3 dead deps; npm audit
fix (8 -> 3). Suite 195 -> 247 (happy-path auth, FIFO oldest-first, flakiness fixes),
isolated on app_test via .env.test with a hard-throw setup guard.

Gates: tsc 0 | build 0 | vitest 247/247 | eslint 0 errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
BOHA
2026-06-09 06:45:26 +02:00
parent c454d1a3fc
commit 519edce373
179 changed files with 7179 additions and 2844 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
src/schemas/settings.schema.ts
View File

@@ -1,4 +1,9 @@
import { z } from "zod";
import {
nonNegativeNumberFromForm,
numberInRange,
emailOrEmpty,
} from "./common";
export const UpdateCompanySettingsSchema = z.object({
company_name: z.string().nullish(),
@@ -12,32 +17,17 @@ export const UpdateCompanySettingsSchema = z.object({
default_currency: z.string().nullish(),
order_type_code: z.string().nullish(),
invoice_type_code: z.string().nullish(),
default_vat_rate: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
default_vat_rate: numberInRange(0, 100).optional(),
require_2fa: z
.preprocess((v) => v === true || v === 1 || v === "1", z.boolean())
.optional(),
break_threshold_hours: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
break_duration_short: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
break_duration_long: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
clock_rounding_minutes: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
invoice_alert_email: z.string().nullish(),
leave_notify_email: z.string().nullish(),
smtp_from: z.string().nullish(),
break_threshold_hours: nonNegativeNumberFromForm.optional(),
break_duration_short: nonNegativeNumberFromForm.optional(),
break_duration_long: nonNegativeNumberFromForm.optional(),
clock_rounding_minutes: numberInRange(0, 1440).optional(),
invoice_alert_email: emailOrEmpty.nullish(),
leave_notify_email: emailOrEmpty.nullish(),
smtp_from: emailOrEmpty.nullish(),
smtp_from_name: z.string().nullish(),
offer_number_pattern: z.string().nullish(),
order_number_pattern: z.string().nullish(),
@@ -48,22 +38,13 @@ export const UpdateCompanySettingsSchema = z.object({
warehouse_issue_number_pattern: z.string().nullish(),
warehouse_inventory_prefix: z.string().nullish(),
warehouse_inventory_number_pattern: z.string().nullish(),
max_login_attempts: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
lockout_minutes: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
max_requests_per_minute: z
.union([z.number(), z.string()])
.transform((v) => Number(v))
.optional(),
available_vat_rates: z.array(z.number()).optional(),
max_login_attempts: numberInRange(1, 100).optional(),
lockout_minutes: numberInRange(1, 1440).optional(),
max_requests_per_minute: numberInRange(1, 100000).optional(),
available_vat_rates: z.array(numberInRange(0, 100)).max(50).optional(),
available_currencies: z.array(z.string()).optional(),
custom_fields: z.array(z.any()).optional(),
supplier_field_order: z.array(z.any()).optional(),
custom_fields: z.array(z.unknown()).max(200).optional(),
supplier_field_order: z.array(z.unknown()).max(200).optional(),
});
export type UpdateCompanySettingsInput = z.infer<