boha_admin/app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

fix: 2026-06-09 full-codebase audit hardening

Browse Source 
Validation: shared NaN-guarded Zod coercion helpers in schemas/common.ts replace
the raw number|string transform idiom across every schema (the root-cause NaN bug
class); emailOrEmpty + lenient isoDateString/timeString.

Security: roles privilege-escalation closed; refresh-token family revocation on
reuse; TOTP uses config params; read endpoints permission-guarded; received-invoices
gross VAT on all paths; orders-pdf custom-items authz.

Concurrency: $queryRaw SELECT...FOR UPDATE locks in ascending-id order (warehouse
confirm/cancel, attendance lockUserRow); uniqueness checks moved into create
transactions (TOCTOU -> 409); deterministic id tiebreak on second-precision
timestamp ordering (plan resolveCell/resolveGrid, warehouse FIFO).

Frontend: Rules-of-Hooks fixed across ~14 pages + PlanCellModal; UTC-date persisted
fields; dashboard invalidation gaps; stale-closure confirm bugs.

Tooling/tests: ESLint flat config (react-hooks/rules-of-hooks = error) + Prettier;
tsconfig.test.json so tsc -b type-checks the tests; removed 3 dead deps; npm audit
fix (8 -> 3). Suite 195 -> 247 (happy-path auth, FIFO oldest-first, flakiness fixes),
isolated on app_test via .env.test with a hard-throw setup guard.

Gates: tsc 0 | build 0 | vitest 247/247 | eslint 0 errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
BOHA
2026-06-09 06:45:26 +02:00
parent c454d1a3fc
commit 519edce373
179 changed files with 7179 additions and 2844 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/routes/admin/project-files.ts
View File

@@ -7,8 +7,30 @@ import { config } from "../../config/env";
import { requirePermission } from "../../middleware/auth";
import { logAudit } from "../../services/audit";
import { success, error } from "../../utils/response";
import { parseBody } from "../../schemas/common";
import { NasFileManager } from "../../services/nas-file-manager";
// Body for POST / (create folder). path defaults to root; the name length cap
// counts code-points (not UTF-16 units) to match the previous handler check.
// Path-traversal safety is enforced downstream by resolveProjectPath.
const CreateFolderSchema = z.object({
folder_name: z
.string()
.trim()
.min(1, "Název složky je povinný")
.refine((s) => [...s].length <= 100, {
message: "Název složky je příliš dlouhý (max 100 znaků)",
}),
path: z.string().optional().default(""),
});
// Body for PUT / (move/rename). Both endpoints are validated by
// resolveProjectPath downstream for traversal safety.
const MoveItemSchema = z.object({
from_path: z.string().min(1, "Zdrojová cesta je povinná"),
to_path: z.string().min(1, "Cílová cesta je povinná"),
});
const ProjectFilesQuerySchema = z.object({
project_id: z.string().min(1, "project_id je povinný"),
path: z.string().optional(),
@@ -117,13 +139,10 @@ export default async function projectFilesRoutes(
return error(reply, "Souborový systém není nakonfigurován", 500);
}
const body = request.body as Record<string, unknown>;
const folderName = String(body.folder_name || "").trim();
const path = String(body.path || "");
if (!folderName) return error(reply, "Název složky je povinný");
if ([...folderName].length > 100)
return error(reply, "Název složky je příliš dlouhý (max 100 znaků)");
const parsedBody = parseBody(CreateFolderSchema, request.body);
if ("error" in parsedBody) return error(reply, parsedBody.error, 400);
const folderName = parsedBody.data.folder_name;
const path = parsedBody.data.path;
// Auto-create project folder if it doesn't exist
if (!fm.projectFolderExists(project.project_number)) {
@@ -233,12 +252,10 @@ export default async function projectFilesRoutes(
return error(reply, "Souborový systém není nakonfigurován", 500);
}
const body = request.body as Record<string, unknown>;
const fromPath = String(body.from_path || "");
const toPath = String(body.to_path || "");
if (!fromPath || !toPath)
return error(reply, "Zdrojová i cílová cesta jsou povinné");
const parsedBody = parseBody(MoveItemSchema, request.body);
if ("error" in parsedBody) return error(reply, parsedBody.error, 400);
const fromPath = parsedBody.data.from_path;
const toPath = parsedBody.data.to_path;
const err = await fm.moveItem(project.project_number, fromPath, toPath);
if (err !== null) return error(reply, err);