boha_admin/app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

fix(numbering): preview the next FREE shared number, not a stale one

Browse Source 
previewSharedNumber returned applyPattern(previewNextSequence) directly. When the number_sequences counter lags behind real data (e.g. orders/projects imported or seeded without bumping it), that raw next sequence is already taken, so the create-project modal showed an already-used number (e.g. OBJ-2026-001) even though generateSharedNumber would correctly assign the next free one via its collision-check loop. Mirror that loop in the preview (without consuming the sequence) so the hint matches what will actually be assigned. Adds two numbering tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
BOHA
2026-06-06 23:02:40 +02:00
parent 56bad52de5
commit 1b372b93ea
2 changed files with 54 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/services/numbering.service.ts
View File

@@ -258,7 +258,18 @@ export async function previewSharedNumber(): Promise<string> {
const code = settings?.order_type_code || "71";
const year = new Date().getFullYear();
const seq = await previewNextSequence("shared", year);
// Mirror generateSharedNumber's collision check (without consuming the
// sequence). The number_sequences counter can lag behind real data — e.g.
// when orders/projects were imported or seeded without bumping it — so the
// raw next sequence may already be taken. Advance past any number already
// used by an order or project, so the preview matches what generateSharedNumber
// would actually assign instead of showing a stale, already-used number.
let seq = await previewNextSequence("shared", year);
for (let attempt = 0; attempt < 1000; attempt++) {
const number = applyPattern(pattern, { year, prefix: "", code, seq });
if (!(await isSharedNumberTaken(number))) return number;
seq++;
}
return applyPattern(pattern, { year, prefix: "", code, seq });
}