boha_admin/app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 26 Wiki Activity

fix(numbering): preview the next FREE offer number, not a stale one

Browse Source 
previewOfferNumber returned applyPattern(previewNextSequence) directly; when the number_sequences 'offer' counter lags behind real quotations, that raw next number is already taken, so the offer editor showed an already-used number (e.g. NA-2026-0001 when 0001/0002 exist). Mirror generateOfferNumber's collision loop in the preview (without consuming the sequence). +2 tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
BOHA
2026-06-07 09:22:44 +02:00
parent c67dff4725
commit 1a0f57a247
2 changed files with 53 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/services/numbering.service.ts
View File

@@ -221,7 +221,17 @@ export async function previewOfferNumber(): Promise<string> {
const prefix = settings?.quotation_prefix || "NA";
const year = new Date().getFullYear();
const seq = await previewNextSequence("offer", year);
// Mirror generateOfferNumber's collision check (without consuming the
// sequence). The number_sequences counter can lag behind real data, so the
// raw next sequence may already be taken — advance past any number already
// used by a quotation so the preview matches what generateOfferNumber assigns
// instead of showing a stale, already-used number.
let seq = await previewNextSequence("offer", year);
for (let attempt = 0; attempt < 1000; attempt++) {
const number = applyPattern(pattern, { year, prefix, code: "", seq });
if (!(await isOfferNumberTaken(number))) return number;
seq++;
}
return applyPattern(pattern, { year, prefix, code: "", seq });
}