fix: audit fix pass #1 — all 19 verified HIGH findings + critical dep cleanup
Fixes every CRITICAL/HIGH finding from the 2026-06-09 full-codebase audit
(REVIEW_FINDINGS.md); each fix went through independent spec + code-quality
review. Plan and per-task log: docs/superpowers/plans/2026-06-10-audit-high-fix-pass.md
- attendance: schemas accept the combined local datetimes the forms/service
use (new dateTimeString helpers in schemas/common.ts), breaks persist on
create, AttendanceCreate submit rebuilt — every submit 400'd since 519edce
- 2fa: backup codes wired to /totp/backup-verify (+ remember-me parity),
enrollment QR generated locally via qrcode (CSP-blocked external service
also leaked the secret), dashboard shows per-user enrollment, not policy
- invoices/orders: per-line VAT survives re-saves (numberOr 0-respecting
coercion in formatters.ts), billing_text persists on update, issued-order
status transitions update UI gates
- trips: real pagination on all 3 pages, GET /trips/stats server aggregate
(shared buildTripsWhere + legacy distance coalesce), vehicle_id applies on
PUT with both-vehicle odometer recompute, print rebuilt (sync window.open,
escaped template, server totals)
- orders api: attachment_data PDF blob excluded from all non-binary reads
- warehouse: unit field is a Select over UnitEnum, receipt attachments
downloadable via new authenticated GET route
- downloads: shared RFC 5987 contentDisposition helper — Czech filenames no
longer 500 (warehouse, received-invoices, orders endpoints)
- misc: block-env hook actually blocks (exit 2 + stderr), project create
works with empty dates, NaN filter guards on trips endpoints
- deps: remove unused concurrently (clears both critical advisories), pin
@hono/node-server >=1.19.13 via overrides (clears the 3 moderates without
the Prisma 6 downgrade), drop deprecated @types stubs
Gates: tsc -b clean - vitest 30 files / 342 tests (31 new) - eslint 0 errors
- build OK
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
import { z } from "zod";
|
||||
import {
|
||||
intIdFromForm,
|
||||
nullableDateTimeString,
|
||||
nullableIntIdFromForm,
|
||||
numberFromForm,
|
||||
numberInRange,
|
||||
@@ -66,19 +67,25 @@ export const AttendancePunchSchema = z.object({
|
||||
address: z.string().max(500).nullish(),
|
||||
});
|
||||
|
||||
// arrival/departure/break fields travel as COMBINED local datetimes
|
||||
// ("YYYY-MM-DDTHH:MM:00", built by the admin forms' combineDatetime from a
|
||||
// date + time input) — the service parses them with `new Date(...)`. They are
|
||||
// NOT bare HH:MM times.
|
||||
export const CreateAttendanceSchema = z.object({
|
||||
user_id: intIdFromForm.optional(),
|
||||
shift_date: z.string(),
|
||||
arrival_time: timeString.nullish(),
|
||||
arrival_time: nullableDateTimeString.optional(),
|
||||
arrival_lat: numberFromForm.nullish(),
|
||||
arrival_lng: numberFromForm.nullish(),
|
||||
arrival_accuracy: numberFromForm.nullish(),
|
||||
arrival_address: z.string().nullish(),
|
||||
departure_time: timeString.nullish(),
|
||||
departure_time: nullableDateTimeString.optional(),
|
||||
departure_lat: numberFromForm.nullish(),
|
||||
departure_lng: numberFromForm.nullish(),
|
||||
departure_accuracy: numberFromForm.nullish(),
|
||||
departure_address: z.string().nullish(),
|
||||
break_start: nullableDateTimeString.optional(),
|
||||
break_end: nullableDateTimeString.optional(),
|
||||
notes: z.string().nullish(),
|
||||
project_id: nullableIntIdFromForm.nullish(),
|
||||
leave_type: z
|
||||
@@ -90,10 +97,10 @@ export const CreateAttendanceSchema = z.object({
|
||||
});
|
||||
|
||||
export const UpdateAttendanceSchema = z.object({
|
||||
arrival_time: timeString.nullish(),
|
||||
departure_time: timeString.nullish(),
|
||||
break_start: timeString.nullish(),
|
||||
break_end: timeString.nullish(),
|
||||
arrival_time: nullableDateTimeString.optional(),
|
||||
departure_time: nullableDateTimeString.optional(),
|
||||
break_start: nullableDateTimeString.optional(),
|
||||
break_end: nullableDateTimeString.optional(),
|
||||
notes: z.string().nullish(),
|
||||
project_id: nullableIntIdFromForm.optional(),
|
||||
leave_type: z.enum(["work", "vacation", "sick", "unpaid"]).optional(),
|
||||
|
||||
Reference in New Issue
Block a user